Skip to content

Stabilize ip_from #141744

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize ip_from #141744

wants to merge 1 commit into from
+6 −7

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented May 29, 2025 •
edited by rustbot
Loading

Tracking issue: #131360

Stabilizes and const-stabilizes the following APIs:

// core::net
impl Ipv4Addr {
    pub const fn from_octets(octets: [u8; 4]) -> Ipv4Addr;
}
impl Ipv6Addr {
    pub const fn from_octets(octets: [u8; 16]) -> Ipv6Addr;
    pub const fn from_segments(segments: [u16; 8]) -> Ipv6Addr;
}

Closes #131360

@rustbot label +needs-fcp

@rustbot
Copy link
Collaborator

rustbot commented May 29, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels May 29, 2025
@jieyouxu
Copy link
Member

r? libs-api

@rustbot rustbot added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label May 30, 2025
@rustbot rustbot assigned m-ou-se and unassigned Mark-Simulacrum May 30, 2025
@jieyouxu jieyouxu removed the T-libs Relevant to the library team, which will review and decide on the PR/issue. label May 30, 2025
@GrigorenkoPV
Copy link
Contributor Author

r? libs-api

@rustbot rustbot assigned Amanieu and unassigned m-ou-se Jun 16, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 19, 2025

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 19, 2025 •
edited by dtolnay
Loading

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 19, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Amanieu Amanieu

Labels
disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for Ipv[46]Address::from_octets, Ipv6Address::from_segments
7 participants
@GrigorenkoPV @rustbot @jieyouxu @Amanieu @rfcbot @m-ou-se @Mark-Simulacrum